feat: Add option to pass QAICInferenceSession to TextGeneration #356
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: quic-shagun <[email protected]>
asmigosw
suggested changes
May 7, 2025
| ) -> None: | ||
| self._ctx_len = ctx_len | ||
| self._write_io_dir = write_io_dir | ||
| self.is_tlm = is_tlm | ||
|
|
||
| # Load QPC | ||
| self._session = QAICInferenceSession(qpc_path, device_id, enable_debug_logs=enable_debug_logs) | ||
| self._session = ( | ||
| session if session else QAICInferenceSession(qpc_path, device_id, enable_debug_logs=enable_debug_logs) |
There was a problem hiding this comment.
Can we store this session somewhere while creating it, so we fetch it from the path directly, somewhat like we do for qpc?
There was a problem hiding this comment.
I don't understand, session is an object of QAICInferenceSession. I need to pass it as a parameter. How can I get it from a path?
There was a problem hiding this comment.
I mean user would not be able to pass this object, so make we make use of object created this time and not have it as a param. Maybe we can make QAICInferenceSession like a singleton class something like below:
class QAICInferenceSession:
session = None
def __new__(cls, *args, **kwargs):
if not cls.session:
cls.session= super(QAICInferenceSession, cls).__new__(cls)
return `cls.session
| @@ -322,6 +322,8 @@ def cloud_ai_100_exec_kv( | |||
| automation=False, | |||
| prompt_to_lora_id_mapping: Optional[List[int]] = None, | |||
| is_tlm: bool = False, | |||
| session: Optional[QAICInferenceSession] = None, | |||
There was a problem hiding this comment.
Can we add this same param in latency_stats_bertstyle function as well so we don't need to create new session there also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time cloud_ai_100_exec_kv is called, a QAICInferenceSession gets created and the model is loaded. This makes the entire execution very slow from an application point of view.
This PR gives the user the option to create a session once and send it to the TextGeneration class to be reused for every call.