Skip to content

Conversation

@mohiso22
Copy link
Contributor

No description provided.

@mohiso22 mohiso22 marked this pull request as ready for review December 23, 2025 07:04
@quic-amitraj
Copy link
Contributor

Refer flux pipeline for the changes and removed not needed class.

@quic-amitraj
Copy link
Contributor

To handle two different types of get_onnx_params for image and video pipelines, let's have two different methods like this:
def get_onnx_image_params(self)

def get_onnx_video_params(self)

Later inside init of pipeline map with the desired method with get_onnx_params like this-
self.vae_decode.get_onnx_params= self.vae_decode.get_onnx_image_params

@quic-amitraj
Copy link
Contributor

To handle two different types of get_onnx_params for image and video pipelines, let's have two different methods like this: def get_onnx_image_params(self)

def get_onnx_video_params(self)

Later inside init of pipeline map with the desired method with get_onnx_params like this- self.vae_decode.get_onnx_params= self.vae_decode.get_onnx_image_params

update flux init as well to reflect this changes.

Copy link
Contributor

@quic-amitraj quic-amitraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mohit Soni and others added 8 commits January 7, 2026 11:34
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: vtirumal <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: vtirumal <[email protected]>
Signed-off-by: Mohit Soni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants