Simplify JSAtom creation #412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use single `JS_NewAtomRT` API to create atoms with or without `ctx` takes a UTF-8 string and flags, optionally detects numeric atoms - simplify `__JS_NewAtom - add `js_realloc_rt2` with slack handling - simplify `JS_NewAtomLen` and `JS_NewAtom̀` - simplify `JS_NewAtomUInt32`, `JS_NewAtomInt64`, `JS_NewClass`
Closed
saghul
approved these changes
Jun 24, 2024
Contributor
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
LGTM, but I left some questions.
| Return `JS_ATOM_NULL` if error. | ||
| Exception is thrown if `ctx` is not a null pointer. | ||
| */ | ||
| static JSAtom __JS_NewAtom(JSRuntime *rt, JSContext *ctx, JSString *str, int atom_type) |
Contributor
There was a problem hiding this comment.
This reads a bit weird. When would one pass rt but not ctx ?
| memcpy(p->u.str8, str, len); | ||
| p->u.str8[len] = '\0'; | ||
| return __JS_NewAtom(rt, p, atom_type); | ||
| if (is_digit(*str) && len < 11) { |
| p->u.str8[len] = '\0'; | ||
| return __JS_NewAtom(rt, p, atom_type); | ||
| if (is_digit(*str) && len < 11) { | ||
| if (*str == '0') { |
Contributor
There was a problem hiding this comment.
Why the special case just for 0 and not for every single digit string?
Contributor
|
Sorry for the delay! |
Contributor
|
Needs a rebase and conflict resolution before it can land but I'm not really sure what value these changes bring. What gets better/faster/stronger? |
|
I don’t really understand why they made those changes, but:
Passing the |
Contributor
|
I think we better close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS_NewAtomRTAPI to create atoms with or withoutctxtakes a UTF-8 string and flags, optionally detects numeric atomsjs_realloc_rt2with slack handlingJS_NewAtomLenandJS_NewAtom̀JS_NewAtomUInt32,JS_NewAtomInt64,JS_NewClass