Skip to content

Conversation

@kndehaan
Copy link
Contributor

@kndehaan kndehaan commented Apr 2, 2025

A new docs page for writing the text for Releases.

@kndehaan kndehaan requested a review from mabijkerk April 2, 2025 12:43
Base automatically changed from slider-text-guide to master April 3, 2025 07:48
@noracato
Copy link
Member

noracato commented Oct 2, 2025

@kndehaan can we merge this?

@kndehaan
Copy link
Contributor Author

kndehaan commented Oct 2, 2025

@noracato it's waiting for @mabijkerk 's review.

Copy link
Member

@mabijkerk mabijkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all I like it. I made some changes to the structure. I would change one more thing though. Instead of the formatted examples, I would actually include a sample unformatted Markdown.

Additionally, I would include that for bigger features, it is recommended to add a picture.

@kndehaan
Copy link
Contributor Author

kndehaan commented Nov 19, 2025

Based on @mabijkerk's comments and considering the new Releases setup in #266, the following needs to be done:

  • Include examples in markdown
  • Include that for bigger features, inserting a picture is recommended
  • Rewrite the piece so that it's aligned with the new Releases setup

@kndehaan kndehaan changed the title Documentation for What's new Documentation for Releases Nov 19, 2025
@kndehaan
Copy link
Contributor Author

kndehaan commented Nov 19, 2025

When #266 has been merged, this branch should be rebased with master and check if the tests pass then (I don't understand yet why they fail now). Subsequently, a final review can be done.

@kndehaan kndehaan requested a review from mabijkerk November 26, 2025 12:00
@kndehaan
Copy link
Contributor Author

Re-review requested. Don't mind all the commits (due to some rebasing with other branches), I'll squash them when merging.

Copy link
Member

@mabijkerk mabijkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add! 🙌

@kndehaan kndehaan merged commit 1d2e90c into master Nov 27, 2025
4 checks passed
@kndehaan kndehaan deleted the whats-new-guide branch November 27, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants