-
Notifications
You must be signed in to change notification settings - Fork 6
Documentation for Releases #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ea87060 to
5eab9bb
Compare
|
@kndehaan can we merge this? |
|
@noracato it's waiting for @mabijkerk 's review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all I like it. I made some changes to the structure. I would change one more thing though. Instead of the formatted examples, I would actually include a sample unformatted Markdown.
Additionally, I would include that for bigger features, it is recommended to add a picture.
4a1388f to
483ed0a
Compare
|
Based on @mabijkerk's comments and considering the new Releases setup in #266, the following needs to be done:
|
483ed0a to
6710e72
Compare
|
When #266 has been merged, this branch should be rebased with |
1e32785 to
ce7ff06
Compare
|
Re-review requested. Don't mind all the commits (due to some rebasing with other branches), I'll squash them when merging. |
mabijkerk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add! 🙌
A new docs page for writing the text for Releases.