Carrier factor factor refactor #1620
Open
+205
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louispt1
force-pushed
the
carrier-multiplier
branch
from
cef05e2 to
ca7b61a
Compare
louispt1
force-pushed
the
carrier-multiplier
branch
from
ca7b61a to
fbb2476
Compare
kndehaan
force-pushed
the
carbon-modelling
branch
2 times, most recently
from
244d11f to
653bf94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow carrier factors to be multiplied on molecule graph connection.
@noracato you may ask - why the refactor? But I tried to stick to the twelve line rule and make it clear / OOP and the original method was already getting quite long and doing parsing etc.
@kndehaan has tested the modelling side of stuff already 👍