Conversation
398591e to
0c92094
Compare
There was a problem hiding this comment.
I think better practice would be using LoggerAdapter to wrap log calls that are already emitted by the system with request_id.
Especially it's relevant for processors: abstract, report and slice. I see that the request_id is available through report_or_slice variable in pre_delegate. I suppose we can wrap the logger instance with LoggerAdapter inside the pre_delegate and then reuse that instance all the way along the class.
You mean something like
In here https://github.com/quipucords/yupana/blob/master/yupana/processor/report_slice_processor.py#L98 ? By reusing it all the way do you mean wrapping it like above and using it in every method call? |
As a beginner in yupana, created this small PR to fix logging of
request_idfor better traceability while debugging issues. Please review and feel free to correct in case something is missing.