-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Spec: Rewrite current proposal into a formal specification
Rewrite the current proposal into a formal specification using normative language. I've converted this file from Markdown to AsciiDoc to enable important navigation and rich-text features that make long-form documents easier to comprehend and link to. Such as an automatic table of contents, section numbering, and "note" blocks for non-normative notes. Added: * Write a new "Terminology" section, with examples to explain how these terms relate to QUnit, Mocha, Jasmine, JUnit and xUnit. * Write down the ordering requirements for events (previously missing). * Write a new "Runner API" section, basically just `on()`. * Write a new "Reporter API" section, basically just `init()`. Changed: * Clarify that Event data is treated as plain objects. Use of private utility classes is allowed, but not required. * Fix type of TestEnd "suite" name to be `string|undefined` since tests under the global suite have undefined as their suite name. Removed: * Remove any sentences about when events emit in relation to execution, so that there is no guruantee or promise of being able to influence or observe test execution by non-standard itself. This is important as otherwise testing frameworks or adapters could not conform to the standard if they use child processes or web workers, or if e.g. a proxy reporter forwards the events over a socket to a server or remote control client where then other reporters can be plugged in. * Remove sentence about deleting `actual` and `expected` properties after emitting TestEnd events "to avoid leaking memory". This was never done in practice and appears to not be an issue in most reporters so long as callbacks just let objects naturally get garbage-collected. * Remove any implied inheritance or other relation between TestStart/TestEnd and SuiteStart/SuiteEnd. This felt confusing because these are not defined as actual classes, and actually were not strictly supersets either because SuiteStart defined a list of TestStart and SuiteStart objects, whereas SuiteEnd is and should be given a list of TestEnd and SuiteEnd objects.
- Loading branch information
Showing
7 changed files
with
455 additions
and
247 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Florentin Simion <[email protected]> | ||
Jiahao Guo <[email protected]> | ||
Trent Willis <[email protected]> | ||
Trent Willis <[email protected]> <[email protected]> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
const cp = require('child_process'); | ||
|
||
function getAuthors () { | ||
const orderedAuthors = cp.execFileSync( | ||
'git', | ||
['log', '--format=%aN', '--reverse'], | ||
{ encoding: 'utf-8' } | ||
); | ||
const unique = orderedAuthors | ||
.trim() | ||
.split('\n') | ||
.filter((author, i, arr) => arr.indexOf(author) === i); | ||
|
||
unique[unique.length - 1] = 'and ' + unique[unique.length - 1]; | ||
|
||
return unique.join(', ') + '.'; | ||
} | ||
|
||
process.stdout.write(getAuthors() + '\n'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,7 @@ | |
"Release", | ||
"Reporter", | ||
"Test", | ||
"Spec", | ||
"Docs" | ||
] | ||
} | ||
|
Oops, something went wrong.