Skip to content

Conversation

qweek
Copy link
Owner

@qweek qweek commented Oct 1, 2020

No description provided.

OlegDokuka and others added 30 commits July 18, 2020 11:28
This PR makes `DefaultPayload.create(ByteBuf, ByteBuf)` behaves consistent with `ByteBufPayload.create(ByteBuf, ByteBuf)` method.

Please note, both methods do not require a user to take any further actions on releasing provided data and metadata `ByteBuf`s. This is a responsibility of the Payload to do so immediately (in the case of `DefaultPayload`) or later, upon the release faze (in case of `ByteBufPayload`)

Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
See gh-890

Signed-off-by: Rossen Stoyanchev <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
improves ref counting and performance subsequently by eliminating redundant retain on the transport level hence we do not need to release this frame on the RSocketRequester/RSocketResponder level anymore

Fixes all duplex connections to follow that strategy

Signed-off-by: Oleh Dokuka <[email protected]>
Closes gh-884

Signed-off-by: Rossen Stoyanchev <[email protected]>
Signed-off-by: Rossen Stoyanchev <[email protected]>
Closes gh-895

Signed-off-by: Rossen Stoyanchev <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
This is the proposed fix for #895 for the 1.1 codebase where
the logic for re-assembling is in a different class than 1.0.

Signed-off-by: Rossen Stoyanchev <[email protected]>
Signed-off-by: Rossen Stoyanchev <[email protected]>
Oleh Dokuka and others added 30 commits April 5, 2023 20:57
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: OlegDokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: OlegDokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: OlegDokuka <[email protected]>
…ion notification

Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: OlegDokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: OlegDokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: OlegDokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: OlegDokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: OlegDokuka <[email protected]>
This PR updates dependencies and makes minor modifications to UnboundedProcessor due to repeating failures of UnboundedProcessorJCStreassTest, which started reproducing some unspotted issues.

Motivation:

UnboundedProcessor is a critical component in the RSocket-Java ecosystem and must work properly. After analysis of its internal state machine, it was spotted that sometimes:

The request may not be delivered due to natural concurrency
The terminal signal may not be delivered since it checks for demand which might be consumed already (due to natural concurrency)
The final value could be delivered violating reactive-streams spec
Modifications:

This PR adds a minimal set of changes, preserving old implementation but eliminating the mentioned bugs

---------

Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>

# Conflicts:
#	build.gradle
#	gradle.properties
It must stay < 1.3 to work with slf4j 1.7.

Signed-off-by: rstoyanchev <[email protected]>
* ensures connection is close on keepalive timeout

Signed-off-by: Oleh Dokuka <[email protected]>

* fix format

Signed-off-by: Oleh Dokuka <[email protected]>

* improve KeepaliveTest

Signed-off-by: Oleh Dokuka <[email protected]>

* fix format and failing test

Signed-off-by: Oleh Dokuka <[email protected]>

* adds reference to the original GH issue

Signed-off-by: Oleh Dokuka <[email protected]>

* fixes google format

Signed-off-by: Oleh Dokuka <[email protected]>

---------

Signed-off-by: Oleh Dokuka <[email protected]>
Fixes gh-1114

Signed-off-by: rstoyanchev <[email protected]>
* ensures connection is close on keepalive timeout

Signed-off-by: Oleh Dokuka <[email protected]>

* fix format

Signed-off-by: Oleh Dokuka <[email protected]>

* improve KeepaliveTest

Signed-off-by: Oleh Dokuka <[email protected]>

* fix format and failing test

Signed-off-by: Oleh Dokuka <[email protected]>

* adds reference to the original GH issue

Signed-off-by: Oleh Dokuka <[email protected]>

* fixes google format

Signed-off-by: Oleh Dokuka <[email protected]>

---------

Signed-off-by: Oleh Dokuka <[email protected]>
Fixes gh-1114

Signed-off-by: rstoyanchev <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Reactor 2020.0.39 -> 2020.0.47
Netty 4.1.106.Final -> 4.1.117.Final
netty-tcnative-boringssl-static 2.0.62.Final -> 2.0.69.Final
Micrometer 1.11.0 -> 1.11.12
Micrometer Tracing 1.1.1 -> 1.1.13

Signed-off-by: rstoyanchev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.