Fuzz duck time, add admin only next command #1297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajax146
requested review from
a team,
dkay0670 and
GalacticalWolf
and removed request for
a team
ajax146
added
Waiting for Review
PR: Want for next release
There was a problem hiding this comment.
Pull Request Overview
This PR adds an admin-only command to display when the next duck will spawn and updates the duck wait function to include a ±10% fuzz to the duck time.
- Introduces a new app_commands group command "next" under the duck command group.
- Updates the wait function to compute a fuzzed wait time before duck appearance.
- Adds the required import for app_commands.
|
|
||
| fuzzed_min = int(min_wait * random.uniform(0.9, 1.1)) | ||
| fuzzed_max = int(max_wait * random.uniform(0.9, 1.1)) | ||
|
|
There was a problem hiding this comment.
The independent fuzzing of min_wait and max_wait may result in fuzzed_min being greater than fuzzed_max, potentially causing random.randint to throw an error. Consider ensuring that the lower bound is always less than or equal to the upper bound.
Suggested change
| if fuzzed_min > fuzzed_max: | |
| fuzzed_min, fuzzed_max = fuzzed_max, fuzzed_min |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a +-10% fuzz to the duck time, and creates an admin only command to view the time the next duck is coming for the guild.
Due to limitations of the loop cog, it's currently not possible to do by channel specifically, so if there is more than one duck hunt channel this feature will be totally broken.