Skip to content

Better factoid json name #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2025
+1 −3
Merged

Better factoid json name #1325

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d638c9
Changes the name of factoid json to match input
ajax146 May 5, 2025
c15f3d4
Add a to lower
ajax146 May 6, 2025
8a1b5f7
Merge branch 'main' into BetterFactoidJsonName
ajax146 May 17, 2025
b5c74cf
Merge branch 'main' into BetterFactoidJsonName
ajax146 May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions techsupport_bot/commands/factoids.py
View file
Original file line number Diff line number Diff line change
@@ -1564,8 +1564,6 @@ async def _json(self: Self, ctx: commands.Context, factoid_name: str) -> None:

factoid = await self.get_factoid(factoid_name, str(ctx.guild.id))

aliases_list = await self.get_list_of_aliases(factoid_name, str(ctx.guild.id))

if not factoid.embed_config:
await auxiliary.send_deny_embed(
message=f"There is no embed config for `{factoid_name}`",
@@ -1578,7 +1576,7 @@ async def _json(self: Self, ctx: commands.Context, factoid_name: str) -> None:
json_file = discord.File(
io.StringIO(formatted),
filename=(
f"{aliases_list[0]}-factoid-embed-config-{datetime.datetime.utcnow()}.json"
f"{factoid_name.lower()}-factoid-embed-config-{datetime.datetime.utcnow()}.json"
),
)