Revise lifecycle of a patch chapter #235 #247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please complete the following sections when you submit your pull request. You are encouraged to keep this top level comment box updated as you develop and respond to reviews. Note that text within html comment tags will not be rendered. --> ### Summary <!-- Describe the problem you're trying to fix in this pull request. --> *Lorem ipsum dolor sit amet, consectetur adipiscing.* <!-- For larger PRs, use bullets with checkboxes to list specific changes. Empty checkboxes indicate that the PR is still a work in progress and not yet ready for review. For simple PRs, you can delete this list. --> - [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* - [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* <!-- Please reference any related issue(s) and use fixes/close to automatically close them, if pertinent. For example: "Fixes r-devel#58", or "Addresses (but does not close) r-devel#238". --> Fixes #<NUM> ### Checklist for adding a new chapter or chapters <!-- Please delete this section if you are not adding a new chapter. Otherwise fill the checkboxes to confirm you have followed all these steps. --> - [ ] Have you updated the [Quick start to the guide](introduction.qmd#quick-start-to-the-guide) accordingly? - [ ] Have you updated the `chapters` field of `_quarto.yml`? This determines the chapter ordering. - [ ] Have you named the new `.qmd` files using lower case, with words separated by `_` if required? ### What should a reviewer concentrate their feedback on? <!-- List any specific aspects for the reviewers to give feedback on, else leave the last bullet --> - [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* - [ ] Everything looks ok? ### Acknowledging contributors List any contributions that need adding to the [table of contributors](https://github.com/r-devel/rdevguide/blob/main/README.md#contributors-). Common contributions are `content` (adding to the guide), `doc` (e.g. README, wiki), `infra` (e.g. GitHub action), and `maintenance` (e.g. fixing links). See the full key to [Contribution Types](https://allcontributors.org/docs/en/emoji-key). - [ ] Please add @<github-username> for <contribution>. Please add @<other-github-username> for <contribution-1>, <contribution-2>. - [ ] **For reviewers**: All relevant contributions have been added, including reviewers, mentors, contributors to the ideas/planning. See [how to acknowledge contributors](https://github.com/r-devel/rdevguide/blob/main/HOWTO-acknowledge-contributors.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lorem ipsum dolor sit amet, consectetur adipiscing.
Fixes #
Checklist for adding a new chapter or chapters
chaptersfield of_quarto.yml? This determines the chapter ordering..qmdfiles using lower case, with words separated by_if required?What should a reviewer concentrate their feedback on?
Acknowledging contributors
List any contributions that need adding to the table of contributors. Common contributions are
content(adding to the guide),doc(e.g. README, wiki),infra(e.g. GitHub action), andmaintenance(e.g. fixing links). See the full key to Contribution Types.