Skip to content

feat: New cast(), capture_cast() and expect_snapshot_cast() #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: New cast(), capture_cast() and expect_snapshot_cast() #66

wants to merge 4 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 30, 2025 •
edited
Loading

Closes #61.

@krlmlr krlmlr requested a review from gaborcsardi April 30, 2025 20:12
@krlmlr
Copy link
Member Author

krlmlr commented Apr 30, 2025

Real-world use case: https://github.com/patperry/r-utf8/pull/72/files#diff-37deacfbc7e0b33ac42e8972fc42ce2ef9221f43339ea72e28249c07083157cf

I wonder why the width measurements seem to be off here. Arguably, this is an edge case.

@krlmlr
Copy link
Member Author

krlmlr commented Apr 30, 2025

The work here could also be turned into a lighter-weight knitr engine. I wonder if there's value in showing the input too.

@krlmlr
Copy link
Member Author

krlmlr commented Jun 8, 2025

@gaborcsardi: What would need to happen to get this (or a variant) to CRAN? Asking for krlmlr/utf8#72 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi Awaiting requested review from gaborcsardi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hand-crafted casts
1 participant
@krlmlr