Skip to content

Realize relative symlinks properly in dir_exists() #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

Realize relative symlinks properly in dir_exists() #397

merged 3 commits into from
Apr 25, 2025

Conversation

heavywatal
Copy link
Contributor

Fixes #395

@gaborcsardi
Copy link
Member

Thanks, and sorry for the long wait!

Seems like link_create() uses junctions on Windows, and AFAICT there are no relative junctions on Windows, so the Windows tests are failing. Let me quickly skip the relative tests on Windows.

@gaborcsardi
Skip defunct tests on Windows
4327caf 
AFAICT there are no relattive junctions on Windows,
and `link_create()` creates junctions on Windows.
@gaborcsardi gaborcsardi merged commit eb03504 into r-lib:main Apr 25, 2025
20 checks passed
@gaborcsardi
Copy link
Member

Thank you again!

@heavywatal heavywatal deleted the dir_exists_relative_symlink branch April 25, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dir_exists sometimes returns FALSE for a relative symlink to a directory
2 participants
@heavywatal @gaborcsardi