-
Notifications
You must be signed in to change notification settings - Fork 195
Logic to make linters robust to adversarial comments #2901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
=======================================
Coverage 99.24% 99.25%
=======================================
Files 129 129
Lines 7319 7335 +16
=======================================
+ Hits 7264 7280 +16
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bumping :) |
Bisaloo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general thought for the future: would it be terrible for performance to add a new xml_parsed_content_nocomments elements in the output of get_source_expression()? To avoid the gymnastics in each individual linter.
True... also more awkward for downstream custom linter authors #2968 |
Split of from #2899. Progress on #2737.
I tried to include here those linters that only fail under "adversarial" commenting, which is a bit subjective, the idea is to basically only consider cases of comments that are not particularly common in practice. In practice that means those listed in the NEWS on #2899 without an associated issue.