Skip to content

Conversation

@MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Jul 26, 2025

Split of from #2899. Progress on #2737.

I tried to include here those linters that only fail under "adversarial" commenting, which is a bit subjective, the idea is to basically only consider cases of comments that are not particularly common in practice. In practice that means those listed in the NEWS on #2899 without an associated issue.

@MichaelChirico MichaelChirico marked this pull request as ready for review July 26, 2025 21:21
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.25%. Comparing base (e67713d) to head (38d3220).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2901   +/-   ##
=======================================
  Coverage   99.24%   99.25%           
=======================================
  Files         129      129           
  Lines        7319     7335   +16     
=======================================
+ Hits         7264     7280   +16     
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico MichaelChirico added this to the 3.3.0 milestone Jul 29, 2025
@MichaelChirico
Copy link
Collaborator Author

Bumping :)

Copy link
Collaborator

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general thought for the future: would it be terrible for performance to add a new xml_parsed_content_nocomments elements in the output of get_source_expression()? To avoid the gymnastics in each individual linter.

@MichaelChirico
Copy link
Collaborator Author

As a general thought for the future: would it be terrible for performance to add a new xml_parsed_content_nocomments elements in the output of get_source_expression()? To avoid the gymnastics in each individual linter.

True... also more awkward for downstream custom linter authors #2968

@MichaelChirico MichaelChirico merged commit 367db02 into main Nov 19, 2025
21 checks passed
@MichaelChirico MichaelChirico deleted the comment-adversarial branch November 19, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants