Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gstat/R/variogramST.R
Line 234 in 8335d8e
With a moderately large data and unspecified
twindow
,tmpInd
will have countless rows, andapply
on it is literally time-consuming. I adapt it for a vectorized computation and the efficiency is much improved.gstat/R/variogramST.R
Lines 255 to 256 in 8335d8e
data[indSp[,1],1]
extracts only one column. For adata.frame
, the default is to drop if only one column is left, and the result reduces to a vector. However, for atibble
, it's not the default.data[indSp[,1],1]
is still atibble
, and hence passing atibble
intomean
returns NA. I adddrop=TRUE
to coercetibble
to drop.