-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FGB attach by group, highlightOptions, label as function #85
Conversation
…hapesLayer for GL
fix: id can be single string or property name feat: expose highlightOptions fix: label can be a function
Merge branch 'fgb_group' of https://github.com/trafficonese/leafem into fgb_group # Conflicts: # inst/htmlwidgets/lib/FlatGeoBuf/fgb.js
The commit 2300146 fixes the options. |
@tim-salabim How do you feel about this PR? Too many potential breaking changes? |
@trafficonese I am not sure about the breaking changes. In all honesty, I forgot about this PR... Let me see if mapview still works with it. |
Seems to not break anything as far as I can see. Is it safe to merge (wrt the layerviewcontrol PR)? |
no worries :) |
Thanks! |
This changes the FGB attachments and uses
group
instead oflayerId
. AlthoughlayerId
cannot be a vector or formula withaddFgb
, I think we should treat the leaflet arguments as similar as possible. But maybe in this case we could ignore that, or what if we expose a new argumentdataSrc
for example and set it to togroup
if it is NULL?Update Flatgeobuf to '3.31.1' from '3.21.3'
expose highlightOptions for mouseover-effect. enable highlighting for fgb mapview#415
mouseEvent will look if
layerId
is a property of the feature, otherwise just returnlayerId
as string. Fix addFgb uses wrong label and layerId #80label
can also be aJS()
function. (see the shiny example below)Some JS-cleanup, fix indentation in
addFlatGeoBufFiltered
, changedvar
tolet
/const
, etc..and sry for the git-commit-mess.. I rebased against master, but in the PR the individal commits are visible again.
Shiny-App