-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pop bench overhead
benchmarking
#432
base: chungquantin/feat-pallet_bench_ui
Are you sure you want to change the base?
feat: pop bench overhead
benchmarking
#432
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## chungquantin/feat-pallet_bench_ui #432 +/- ##
====================================================================
Coverage ? 75.02%
====================================================================
Files ? 71
Lines ? 15640
Branches ? 15640
====================================================================
Hits ? 11734
Misses ? 2373
Partials ? 1533
|
pop bench overhead
benchmarking
0767eb8
to
9ee7ea6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small comments, but it's a great PR, no blockers. Approved!
Amazing job, Tin!
673a9e0
to
d60e9b4
Compare
use pop_parachains::generate_overhead_benchmarks; | ||
|
||
#[derive(Args)] | ||
pub struct BenchmarkOverhead { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Public docs (including field)
} | ||
|
||
impl BenchmarkOverhead { | ||
pub async fn execute(&mut self, cli: &mut impl cli::traits::Cli) -> anyhow::Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function docs
This PR is a part of a large PR #424. It implements the
pop bench overhead
command.Deliverables
How to test the PR?
Run the below command to test the feature quickly
There is a new command flag provided to skip the interactive UI