Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pop bench overhead benchmarking #432

Open
wants to merge 14 commits into
base: chungquantin/feat-pallet_bench_ui
Choose a base branch
from

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Mar 3, 2025

This PR is a part of a large PR #424. It implements the pop bench overhead command.

Screenshot 2025-03-06 at 19 12 52

Deliverables

  • Prompt to select runtime
  • Prompt to select genesis builder
  • Prompt to input the directory path of weight files
  • Skip interactive UI feature

How to test the PR?

Run the below command to test the feature quickly

pop bench overhead --warmup=1 --repeat=1

There is a new command flag provided to skip the interactive UI

pop bench overhead --warmup=1 --repeat=1 -i

@chungquantin chungquantin self-assigned this Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 63.10345% with 107 lines in your changes missing coverage. Please review.

Please upload report for BASE (chungquantin/feat-pallet_bench_ui@298e12b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/pop-cli/src/common/bench.rs 75.00% 28 Missing and 26 partials ⚠️
crates/pop-cli/src/commands/bench/overhead.rs 27.65% 31 Missing and 3 partials ⚠️
crates/pop-parachains/src/bench/mod.rs 0.00% 10 Missing ⚠️
crates/pop-cli/src/commands/bench/pallet.rs 50.00% 8 Missing ⚠️
crates/pop-cli/src/commands/bench/mod.rs 0.00% 1 Missing ⚠️
@@                         Coverage Diff                          @@
##             chungquantin/feat-pallet_bench_ui     #432   +/-   ##
====================================================================
  Coverage                                     ?   75.02%           
====================================================================
  Files                                        ?       71           
  Lines                                        ?    15640           
  Branches                                     ?    15640           
====================================================================
  Hits                                         ?    11734           
  Misses                                       ?     2373           
  Partials                                     ?     1533           
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/bench/mod.rs 0.00% <0.00%> (ø)
crates/pop-cli/src/commands/bench/pallet.rs 71.54% <50.00%> (ø)
crates/pop-parachains/src/bench/mod.rs 85.20% <0.00%> (ø)
crates/pop-cli/src/commands/bench/overhead.rs 27.65% <27.65%> (ø)
crates/pop-cli/src/common/bench.rs 71.56% <75.00%> (ø)

@chungquantin chungquantin mentioned this pull request Mar 3, 2025
6 tasks
@chungquantin chungquantin changed the title feat: overhead benchmarking feat: pop bench overhead benchmarking Mar 3, 2025
@chungquantin chungquantin force-pushed the chungquantin/feat-overhead_benchmarking branch 2 times, most recently from 0767eb8 to 9ee7ea6 Compare March 5, 2025 06:08
@chungquantin chungquantin marked this pull request as ready for review March 5, 2025 07:30
@chungquantin chungquantin requested a review from AlexD10S March 6, 2025 12:13
@chungquantin chungquantin added the ready-for-final-review The PR is ready for final review label Mar 6, 2025
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small comments, but it's a great PR, no blockers. Approved!
Amazing job, Tin!

@chungquantin chungquantin force-pushed the chungquantin/feat-overhead_benchmarking branch from 673a9e0 to d60e9b4 Compare March 7, 2025 06:41
use pop_parachains::generate_overhead_benchmarks;

#[derive(Args)]
pub struct BenchmarkOverhead {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public docs (including field)

}

impl BenchmarkOverhead {
pub async fn execute(&mut self, cli: &mut impl cli::traits::Cli) -> anyhow::Result<()> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public function docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-final-review The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants