-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the filter mode to Cli
#435
base: main
Are you sure you want to change the base?
Conversation
Cli
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## chungquantin/chore-deny_action_v2 #435 +/- ##
=====================================================================
- Coverage 75.46% 75.28% -0.18%
=====================================================================
Files 64 64
Lines 14108 14029 -79
Branches 14108 14029 -79
=====================================================================
- Hits 10646 10562 -84
- Misses 2100 2120 +20
+ Partials 1362 1347 -15
|
CI is failing in deny and docker. I see the Also I see some clippy warnings. |
For the CI, let me update the #431 to include that error as well and we merge that first. I would love to resolve an issue with the CI asap. For the clippy warnings, because we don't use those methods anywhere yet. They are expected to be used in the interactive UI of pallet benchmarking PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just a nitpick, before merging fix a warning message, with the zombinet-sdk upgrade
warning: use of deprecated method `pop_parachains::NetworkNode::client`: Use `wait_client` instead.
--> crates/pop-cli/src/commands/up/network.rs:174:61
|
174 | ... let relay_endpoint = network.relaychain().nodes()[0].client().await?;
9990d43
to
981b5f4
Compare
981b5f4
to
e470707
Compare
e470707
to
33b370b
Compare
Add the new method
filter_mode()
to theCli
struct that enables the filter mode to theSelect
andMultiSelect
. We need this feature for the #420The implementation PR of the filter mode in cliclack that includes images of how the feature looks like.