Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardcoded test failing in the CI #448

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Mar 9, 2025

After the updates in the pop-node release, one test was failing in the CI (https://github.com/r0gue-io/pop-cli/actions/runs/13666853327/job/38359250240?pr=435) due to a hardcoded value for the node name, pop-devnet which is no longer applicable in the new release. The hardcoded value has been removed.

Additionally, this update fixes cargo deny in the CI by bumping dependency versions. It was automatic done by the dependabot #447. But deny was still failing so had to add a vulnerability in the deny.toml.

The PR introduces two new vulnerability dependency:

@AlexD10S AlexD10S requested a review from chungquantin March 9, 2025 19:19
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (8492820) to head (bc0acf2).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   75.46%   75.45%   -0.01%     
==========================================
  Files          64       64              
  Lines       14108    14107       -1     
  Branches    14108    14107       -1     
==========================================
- Hits        10647    10645       -2     
- Misses       2099     2100       +1     
  Partials     1362     1362              
Files with missing lines Coverage Δ
crates/pop-parachains/src/build.rs 88.15% <ø> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants