Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r3bl_core] Add decl macro to create singleton, and fix doc tests #370

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[r3bl_core] Add decl macro to create singleton, and fix doc tests #370

merged 1 commit into from
Dec 4, 2024

Conversation

nazmulidris
Copy link
Member

  1. create_global_singleton!
  • takes a struct that implement Default trait
  • and can make it a global mutable singleton that is thread safe
  • uses no unsafe code.
  1. fix all doc tests
  • stop using ignore in doc tests
  • write code that at least compiles, if it does not run, using no_run

@nazmulidris nazmulidris linked an issue Dec 4, 2024 that may be closed by this pull request
[r3bl_core] create decl macro to make it easy to generate global mutable variables (singleton) #369
Closed
4 tasks
@nazmulidris nazmulidris force-pushed the 369-singleton-doc-comments branch 4 times, most recently from 37f4cba to 4a4c515 Compare December 4, 2024 14:38
@nazmulidris
[r3bl_core] Add decl macro to create singleton, and fix doc tests
20fe5e7 
1. create_global_singleton!
  - takes a struct that implement Default trait
  - and can make it a global mutable singleton that is thread safe
  - uses no unsafe code.

2. fix all doc tests
  - stop using `ignore` in doc tests
  - write code that at least compiles, if it does not run, using
    `no_run`

3. update main `run` nushell script to run `audit-deps` function in
   the `all-cicd` function
  - whitelist 3 RUSTSEC advisories for crates that are old or
    unmaintained:
    - `instant`
    - `hashbrown`
    - `yaml-rust`
@nazmulidris nazmulidris force-pushed the 369-singleton-doc-comments branch from 4a4c515 to 20fe5e7 Compare December 4, 2024 14:46
@nazmulidris nazmulidris merged commit 2b01bc6 into main Dec 4, 2024
1 check passed
@nazmulidris nazmulidris deleted the 369-singleton-doc-comments branch December 4, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[r3bl_core] create decl macro to make it easy to generate global mutable variables (singleton)
1 participant
@nazmulidris