ra_server: Ignore #info_reply{} from a node that is not part of cluster
#536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster
[Why]
Between the time a node asks for another node's information and the time
it gets the reply, it is possible that this other node leaves the
cluster for whatever reason.
This causes a crash of the Ra server that asked the information because
it accesses the `cluster` map to get the state of the node that emitted
the `#info_reply{}` without checking first if the node is still part of
the cluster (i.e., there is a key corresponding to that node in the
`cluster` map).
To be exact, line 3651 raises a `badkey` exception:
PeerState0 = maps:get(PeerId, Cluster),
[How]
We simply ignore the `#info_reply{}` from a node that is not present in
the `cluster` map.
kjnilsson
approved these changes
Apr 8, 2025
dumbbell
added a commit
to rabbitmq/khepri
that referenced
this pull request
Apr 8, 2025
Release notes: https://github.com/rabbitmq/ra/releases/tag/v2.16.7 In particular, it contains a bug fix around the handling of `#info_reply{}` (rabbitmq/ra#536).
dumbbell
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Apr 8, 2025
Release notes: https://github.com/rabbitmq/ra/releases/tag/v2.16.7 What's changed: * ra_server: Ignore `#info_reply{}` from a node that is not part of cluster (rabbitmq/ra#536).
mergify bot
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Apr 8, 2025
Release notes: https://github.com/rabbitmq/ra/releases/tag/v2.16.7 What's changed: * ra_server: Ignore `#info_reply{}` from a node that is not part of cluster (rabbitmq/ra#536). (cherry picked from commit 8dec1ab)
michaelklishin
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Apr 24, 2025
Release notes: https://github.com/rabbitmq/ra/releases/tag/v2.16.7 What's changed: * ra_server: Ignore `#info_reply{}` from a node that is not part of cluster (rabbitmq/ra#536).
ikavgo
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
May 5, 2025
Release notes: https://github.com/rabbitmq/ra/releases/tag/v2.16.7 What's changed: * ra_server: Ignore `#info_reply{}` from a node that is not part of cluster (rabbitmq/ra#536).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Between the time a node asks for another node's information and the time it gets the reply, it is possible that this other node leaves the cluster for whatever reason.
This causes a crash of the Ra server that asked the information because it accesses the
clustermap to get the state of the node that emitted the#info_reply{}without checking first if the node is still part of the cluster (i.e., there is a key corresponding to that node in theclustermap).To be exact, line 3651 raises a
badkeyexception:How
We simply ignore the
#info_reply{}from a node that is not present in theclustermap.