fix: upload security extractor false positives (logging and SVG sanitization) - #42
fix: upload security extractor false positives (logging and SVG sanitization)#42google-labs-jules[bot] wants to merge 1 commit into
Conversation
Tightened the KEY_FROM_NAME regex to prevent flagging when originalname is used purely for logging. Added SVG_SANITIZE regex to safely allow SVG uploads when DOMPurify.sanitize or sanitizeHtml is explicitly used. Added two regression tests to test_pentest_regressions.py to lock in these fixes. Fixed a test flake in test_hooks.py by setting core.hooksPath locally. Updated CHANGELOG.md with the fixes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
upload_securityextractor regexes to eliminate two false positive scenarios:upload-key-from-filenamewhen purely logging theoriginalnameandupload-accepts-svgwhen explicitly using sanitization functions likeDOMPurify.PR created automatically by Jules for task 2686765769083336356 started by @raccioly