Tighten SERVE_FILE regex to prevent generic createReadStream false positives - #44
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What
Tightened the
SERVE_FILEregex insrc/websec_validator/extractors/upload_security.pyto eliminate false positives for generic file reading calls (createReadStream,\.getObject\() that were not piped to an HTTP response sink.Why
The old regex was too broad and flagged internal, benign uses of
fs.createReadStreamands3.getObject(...)in Node.js/AWS backend code, leading to incorrectserve-no-nosniffalerts (false positives) when those files weren't even served to clients. By explicitly requiring a sink connection, e.g.,.pipe(res), or checking for sink methods directly (res.sendFile,proxyMedia), we drastically reduce noise without impacting true positives.Risk
Low. Zero true positive tests regressed. 4 regression tests added to
tests/test_pentest_regressions.pyunderFalsePositiveRegressionTests.docguard guardremains perfectly clean.PR created automatically by Jules for task 4019915604445840177 started by @raccioly