Skip to content

Conversation

@manishtomar
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Sep 20, 2016

Current coverage is 92.45% (diff: 100%)

Merging #1933 into master will not change coverage

@@             master      #1933   diff @@
==========================================
  Files            83         83          
  Lines          7424       7424          
  Methods           0          0          
  Messages          0          0          
  Branches       1008       1008          
==========================================
  Hits           6864       6864          
  Misses          463        463          
  Partials         97         97          

Powered by Codecov. Last update 6df2b82...e073089

@manishtomar
Copy link
Contributor Author

@meker12 review please.

Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested changes

Convergence ensures that all servers are always attached to their respective
load balancers. Hence, deleting a load balancer that was originally configured in the
scaling group will result that group in ``ERROR``.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manishtomar This is a little confusing. The last sentence of this bullet seems to duplicate the information in the previous bullet item.

What do you mean by changing the load balancer in the launch configuration? ---

Here's some suggestions to clarify what you mean:

If change = delete or add a load balancer

When you delete a load balancer, x happens. You have to do y.
When you add a load balancer, x happens.... You have to y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants