Automated Resyntax fixes #745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
The `displayln` function can be used to display a value with a newline after it.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
This `for-each` operation can be replaced with a `for` loop.
Using `cond` instead of `if` here makes `begin` unnecessary
This `hash-for-each` operation can be replaced with a `for` loop.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
flat-contract is a legacy form for constructing contracts from predicates; predicates can be used directly as contracts now.
rfindler
reviewed
Jun 2, 2025
| (define is-module? | ||
| (syntax-case sexp (module) | ||
| [(module . rest | ||
| ) |
There was a problem hiding this comment.
@sorawee is this your department?
There was a problem hiding this comment.
Yes :/. This particular instance should be easy to fix.
rfindler
reviewed
Jun 2, 2025
| 15))] | ||
| ["??"]))) | ||
| frames)) | ||
| (define trimmed-lengths (map add1 (map string-length trimmed-exprs))) |
There was a problem hiding this comment.
looks like trimmed-lengths also isn't used.
|
If someone wants to fix the two things above and merge, that's okay with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 5 files.
let-to-definecond-let-to-cond-definehash-for-each-to-forif-let-to-condfor-each-to-formap-to-forflat-contract-migrationdisplay-and-newline-to-displaylnif-begin-to-cond