Move emit module into the text-lib package
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages relying on bindings from this module like `emit-local-step` transitively inherit the broader doc dependencies in the `macro-debugger` package. Moving this to the text-lib package allows these packages to avoid those transitive dependencies. Suggested by Sam TH to address racket#47.
|
I rebuilt Qi locally using this branch after changing the lib dependency to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages relying on bindings from this module like
emit-local-steptransitively inherit the broader doc dependencies in themacro-debuggerpackage. Moving this to the text-lib package allows these packages to avoid those transitive dependencies.Suggested by Sam TH to address #47.