Skip to content

Move emit module into the text-lib package #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

countvajhula
Copy link

Packages relying on bindings from this module like emit-local-step transitively inherit the broader doc dependencies in the macro-debugger package. Moving this to the text-lib package allows these packages to avoid those transitive dependencies.

Suggested by Sam TH to address #47.

Packages relying on bindings from this module like `emit-local-step`
transitively inherit the broader doc dependencies in the
`macro-debugger` package. Moving this to the text-lib package allows
these packages to avoid those transitive dependencies.

Suggested by Sam TH to address racket#47.
@countvajhula
Copy link
Author

countvajhula commented Mar 15, 2025

I rebuilt Qi locally using this branch after changing the lib dependency to macro-debugger-text-lib, and it built successfully. I also verified that expansion events generated during Qi compilation show correctly in the Macro Stepper. I also didn't see any modules within the macro-debugger package depending on the emit.rkt module using a relative path (i.e., as "...emit.rkt" instead of as macro-debugger/emit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant