Repository navigation
Point relocated ARM xrefs at Thumb entries ##analysis - #26934
Merged
Merged
Conversation
Collaborator
|
I was expecting a much larger patch! Lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With relocations applied, an ARM PLT stub that loads a Thumb function pointer records its CODE xref one byte past the function entry:
0x2d588when the instruction reads a relocation slot whose Thumb symbol matches that address exactly. Resolve both the slot and symbol in the loaded address space, including-B.The libarm/g711 PLT, rebased-load, and raw/even search cases fail without the fix. Controls cover mismatched slot contents, ARM symbols, missing relocation provenance, register branches, and unrelated veneers. The g711 case also checks that subsequent
anal.callsanalysis keeps the real Thumb function intact.