Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the two expected failures encountered while validating the OSS Scanner enrollment:
ELF: core sections with reg nameandcreate pe x86-64.Two commits:
.reg,.reg2, and.reg-xstatesections, with thread IDs and aliases for the first thread. Share bounded note parsing with register-state extraction, check note owners and descriptor lengths, and correct the i386 register-set size.pe64could not create a file andpe -b 64silently emitted PE32.Remove both
BROKENmarkers. Check actual register-section names, offsets and sizes, and generated PE architecture, header magic, entry-point bytes and data mapping. Add malformed-note and multiple-thread coverage. PE output now uses standard file/section alignment rather than the former overlapping 125-byte layout.The existing core disassembly expectation loses segment metadata comments because radare2 suppresses them when sections are present; register values and instructions are unchanged.
Validation:
make -j4and installation succeeded.r2r -u -L -C test db/formats/elf db/formats/pe: 771 passed, 0 failed, 0 broken, 2 skipped.objdump.git diff --checkpasses.Validation ran on Linux; generated PE files were parsed, not executed on Windows.