Skip to content

Add graph.cmt.col for aligned VV/agf comments - #26941

Closed
omar-khallaf wants to merge 1 commit into
radareorg:masterfrom
omar-khallaf:graph-cmt-col
Closed

omar-khallaf wants to merge 1 commit into
radareorg:masterfrom
omar-khallaf:graph-cmt-col

Conversation

@omar-khallaf

@omar-khallaf omar-khallaf commented Oct 10, 2026 •

Copy link
Copy Markdown

Graph nodes forced asm.cmt.col=0 in get_body(), so VV/agf comments rendered ragged (instr + 1 space + ;) while pdf honored asm.cmt.col.

This adds a dedicated graph.cmt.col (default 0 = today's ragged behavior, backward compatible) that drives the inner pD column, independent of pdf. Example: e graph.cmtright=true; e graph.cmt.col=30.

  • libr/core/cconfig.c: register SETI graph.cmt.col
  • libr/core/agraph.c get_body(): pass graph.cmt.col instead of forced 0 (hold/restore intact)

Verified: clean ninja build; agf on varying-length function shows ragged at 0, aligned at 30.

Graph nodes forced asm.cmt.col=0 so comments rendered ragged.
New graph.cmt.col (default 0, old behavior) drives the inner pD
column, independent of pdf asm.cmt.col. e.g. e graph.cmt.col=30.

Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant