Skip to content

Commit

Permalink
Merge pull request #1179 from radian-software/rr-docker-ratelimits
Browse files Browse the repository at this point in the history
Resolve Docker Hub rate limits
  • Loading branch information
raxod502 authored Jan 22, 2025
2 parents 7e3d8a0 + d80c077 commit d74c9cc
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 7 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,21 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
emacs_version: [25, 26, 27, 28]
emacs_version: [25, 26, 27, 28, 29]
steps:
- name: Checkout
uses: actions/checkout@v4
- name: GHCR login
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: CI
env:
VERSION: ${{ matrix.emacs_version }}
run: >-
make docker CMD="make -k compile checkdoc longlines test smoke"
make docker
CMD="make -k compile checkdoc longlines test smoke"
DOCKER_BASE=ghcr.io/radian-software/emacs-base
NO_SUDO_DOCKER=1
5 changes: 3 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
ARG VERSION
FROM silex/emacs:$VERSION
ARG BASE=silex/emacs
ARG VERSION=29
FROM $BASE:$VERSION

ARG UID

Expand Down
8 changes: 5 additions & 3 deletions scripts/docker.bash
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,16 @@
set -e
set -o pipefail

tag="${1:-latest}"
tag="${1:-29}"

args=(bash)
if [[ -n "$2" ]]; then
args=("${args[@]}" -c "$2")
fi

docker() {
if [[ "$OSTYPE" != darwin* ]] && [[ "$EUID" != 0 ]]; then
if [[ "$OSTYPE" != darwin* ]] && [[ "$EUID" != 0 ]] \
&& [[ -z "${NO_SUDO_DOCKER:-}" ]]; then
command sudo docker "$@"
else
command docker "$@"
Expand All @@ -20,7 +21,8 @@ docker() {

docker build . -t "straight.el:$tag" \
--build-arg "UID=$UID" \
--build-arg "VERSION=$tag"
--build-arg "VERSION=$tag" \
--build-arg "BASE=${DOCKER_BASE:-silex/emacs}"

it=()

Expand Down

0 comments on commit d74c9cc

Please sign in to comment.