feat: Add rad terraform CLI commands #11049
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds new rad terraform CLI commands to manage Terraform installation within Radius. The feature allows users to install, uninstall, and check the status of Terraform, which is used for executing Terraform recipes.
Changes:
- Introduces three new subcommands under
rad terraform: install, uninstall, and status - Implements a shared HTTP client for communicating with the Terraform installer API
- Adds comprehensive test coverage including unit tests and validation tests
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/cmd/terraform/terraform.go | Parent command definition for rad terraform |
| pkg/cli/cmd/terraform/install/install.go | Install command with support for version/URL, wait, TLS options |
| pkg/cli/cmd/terraform/install/install_test.go | Comprehensive tests for install command including validation and integration scenarios |
| pkg/cli/cmd/terraform/uninstall/uninstall.go | Uninstall command with wait support and status tracking |
| pkg/cli/cmd/terraform/uninstall/uninstall_test.go | Tests for uninstall command covering various scenarios |
| pkg/cli/cmd/terraform/status/status.go | Status command to display current Terraform installation info |
| pkg/cli/cmd/terraform/status/status_test.go | Tests for status command |
| pkg/cli/cmd/terraform/status/objectformats.go | Table formatting for status output |
| pkg/cli/cmd/terraform/status/objectformats_test.go | Tests for output formatting |
| pkg/cli/cmd/terraform/common/client.go | Shared HTTP client for installer API interactions |
| cmd/rad/cmd/root.go | Registration of new terraform commands in CLI |
sylvainsf
reviewed
Jan 22, 2026
| deadline := time.Now().Add(r.Timeout) | ||
| pollInterval := r.PollInterval | ||
|
|
||
| for { |
Contributor
There was a problem hiding this comment.
The success check requires both the version state to be "succeeded" AND CurrentVersion == r.Version. This could cause the loop to continue indefinitely if the version succeeds but isn't set as current. We should return an error in this case unless server side has guarantees that install will never succeed without changing current.
ytimocin
force-pushed
the
ytimocin/terraform-bicep-settings/terraform-cli
branch
from
0d57464 to
42f3802
Compare
ytimocin
force-pushed
the
ytimocin/terraform-bicep-settings/terraform-controller
branch
2 times, most recently
from
d752abe to
44ad765
Compare
ytimocin
force-pushed
the
ytimocin/terraform-bicep-settings/terraform-cli
branch
from
42f3802 to
ecfe23d
Compare
9 tasks
ytimocin
force-pushed
the
ytimocin/terraform-bicep-settings/terraform-controller
branch
4 times, most recently
from
47b62db to
b41ae3d
Compare
Base automatically changed from
ytimocin/terraform-bicep-settings/terraform-controller
to
features/terraform-bicep-settings
January 24, 2026 05:29
ytimocin
force-pushed
the
ytimocin/terraform-bicep-settings/terraform-cli
branch
from
ecfe23d to
f2b10c9
Compare
ytimocin
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
ytimocin
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
Signed-off-by: ytimocin <ytimocin@microsoft.com>
ytimocin
force-pushed
the
ytimocin/terraform-bicep-settings/terraform-cli
branch
from
f2b10c9 to
2d39529
Compare
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made.
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: