-
Notifications
You must be signed in to change notification settings - Fork 14
Add Azure recipe for the Radius.Data/mySqlDatabases resource type #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Azure recipe for the Radius.Data/mySqlDatabases resource type #56
Conversation
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Implementation of radius-project/design-notes#110 --------- Signed-off-by: Zach Casper <[email protected]> Signed-off-by: Andrew Matveychuk <[email protected]>
This PR adds documentation for automated workflow testing. Testing is only required for stable resource types. The following changes have been made: - Move the build folder into .github - Add documentation for adding tests for stable resource types - Add documentation for make targets - Removed bicepconfig.json and generate it during automated workflow runs --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
…o major MySQL version property Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
…ameter tp honor the type specification Signed-off-by: Andrew Matveychuk <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Andrew Matveychuk <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Andrew Matveychuk <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: Andrew Matveychuk <[email protected]>
…ters to account for the inputs from the recipe context object Signed-off-by: Andrew Matveychuk <[email protected]>
…template generalization Signed-off-by: Andrew Matveychuk <[email protected]>
This reverts commit e82725d. Signed-off-by: Andrew Matveychuk <[email protected]>
This reverts commit 3a6e7ce. Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
… type Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
|
@Reshrahim @zachcasper Could you please review and let me know your thoughts? |
|
The PR to update the documentation for the Azure provider with missing details: radius-project/docs#1539 |
Reshrahim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
I made some suggestions as I manually tested the Azure Recipe. I was able to deploy but the env variables did not get populated on the container via connections.
Data/mySqlDatabases/recipes/azure-database-for-mysql/bicep/azure-database-for-mysql.bicep
Show resolved
Hide resolved
Data/mySqlDatabases/recipes/azure-database-for-mysql/bicep/azure-database-for-mysql.bicep
Outdated
Show resolved
Hide resolved
…ation for maximum length Signed-off-by: Andrew Matveychuk <[email protected]>
…operty default values Signed-off-by: Andrew Matveychuk <[email protected]>
…come the current limitation of working with secrets in Radius Signed-off-by: Andrew Matveychuk <[email protected]>
FYI, I'm still looking into this, and I'm trying to accomodate the TLS enforcement into the recipe. |
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
Signed-off-by: Andrew Matveychuk <[email protected]>
@Reshrahim |
|
@andrewmatveychuk - Can you review https://github.com/radius-project/resource-types-contrib/pull/95/changes#diff-efca8759f11a6cd43d11b7c4f5948402d7d743097b2f08ed6a970d897bfbb618 as a pattern for modeling secrets and start updating the mysql type. This will be published as the guidance on modeling secrets with types once the core types (extensible) are added to the Radius install |
Description
Related PR: #46
Testing
From the repository root folder:
rad resource-type create -f '.\Data\mySqlDatabases\mySqlDatabases.yaml'rad bicep publish-extension -f '.\Data\mySqlDatabases\mySqlDatabases.yaml' --target '.\Data\mySqlDatabases\radiusResources.tgz'rad bicep publish --file '.\Data\mySqlDatabases\recipes\azure-database-for-mysql\bicep\azure-database-for-mysql.bicep' --target 'br:ghcr.io/andrewmatveychuk/azure-database-for-mysql:0.54'rad recipe register default --environment default --resource-type 'Radius.Data/mySqlDatabases' --template-kind bicep --template-path 'ghcr.io/andrewmatveychuk/kubernetes-mysql:0.54'