[Slot] support slotting onto nested children #3695
Closed
+593
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6e334fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 44 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jjenzz
force-pushed
the
slot-improvements
branch
from
56797c0 to
60c567c
Compare
jjenzz
commented
Oct 6, 2025
packages/react/slot/src/slot.tsx
Outdated
Comment on lines
21
to
22
| if (process.env.NODE_ENV === 'development') console.warn(createSlotWarning(ownerName)); | ||
| return children; |
There was a problem hiding this comment.
If it cannot slot, we don't throw anymore... it renders the children as normal with a warning. I wasn't sure what was best here tbh.
jjenzz
force-pushed
the
slot-improvements
branch
from
60c567c to
e5d7103
Compare
jjenzz
force-pushed
the
slot-improvements
branch
from
e5d7103 to
6e334fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is inspired by #2197 and should resolve #3626, but I've made it backwards compatible and also improved the implementation of
Slotslightly:Slot.SlotClonecompsReact.Children.only()error with a more intuitive warningssr-testing