-
Notifications
You must be signed in to change notification settings - Fork 95
Add Qwen3-14B B300 training script #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @harvenstar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a dedicated training script for the Qwen3-14B large language model, specifically designed for execution on B300 GPUs. The script encapsulates a full training configuration, from data handling and model checkpointing to performance tuning and distributed execution via Ray, addressing specific hardware considerations to ensure efficient model training. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a training script for Qwen3-14B. A security audit revealed a potential command injection vulnerability from unquoted environment variable expansion and an insecure default configuration exposing the Ray dashboard without authentication. These critical security issues must be addressed to prevent unauthorized access and code execution. Additionally, the script's process cleanup logic needs safety enhancements, and a typo in an environment variable should be corrected.
- Start from docker pull instead of assuming running inside container - Remove pkill cleanup and NVLink detection (hardcode NCCL_NVLS_ENABLE=1) - Fix PYTHONBUFFERED typo → PYTHONUNBUFFERED - Quote MASTER_ADDR properly - Inline MODEL_ARGS (container heredoc can't source host files) - Data paths use /data mount point (DATA_DIR configurable)
- Use /.dockerenv detection for single-file host/container dual mode - Add process cleanup (pkill sglang/ray/python) matching other scripts - Source model args from scripts/models/qwen3-14B.sh instead of inlining - Detect NVLink dynamically instead of hardcoding NCCL_NVLS_ENABLE - Fix heredoc stdin issue by adding docker run -i flag - Add --working-dir /root/miles for correct train.py resolution
Summary
Test plan