Skip to content

Conversation

@felixcremer
Copy link
Contributor

This should fix #1047 by adding the force to the RasterCreator struct and so to be used as a keyword to rasterize.

I added the changes to test_utils, because I ran into test failures because I had a manually created tempname tif file in my temp folder which interfered with the RasterSeries tests. This adds a temporary dir so that every use of the temporary raster construction uses a separate folder.

Locally I get some seemingly unrelated failures due to some RASTERDATASOURCE variable not set in ENV. I don't understand why this failure comes up with these changes.

This is so that other tif files in the tempdir is not interfering with the Raster tests.
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (f1c4b75) to head (6f03793).
⚠️ Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
+ Coverage   82.89%   83.72%   +0.83%     
==========================================
  Files          58       68      +10     
  Lines        5425     5481      +56     
==========================================
+ Hits         4497     4589      +92     
+ Misses        928      892      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tiemvanderdeure
Copy link
Collaborator

Locally I get some seemingly unrelated failures due to some RASTERDATASOURCE variable not set in ENV

We need that for rasterdatasources tests, but it is set in ci.yml, so not really a failure

@felixcremer
Copy link
Contributor Author

Could we set this somehow also locally. Because it is annoying to have local tests failures due to that. Could we instead of setting them via a yml as ENV["RASTERDATASOURCES_PATH"] from within julia in the tests that need it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forward force keyword in rasterize

2 participants