-
Notifications
You must be signed in to change notification settings - Fork 140
Rearrange, not change the abilities in Ability #997
Commits on May 15, 2018
-
WIP Rearrange, not change the abilities in Ability, cf recommended be…
…st practices This is the work doc. Reset to here before continuing
Configuration menu - View commit details
-
Copy full SHA for d00277c - Browse repository at this point
Copy the full SHA d00277cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27ead4d - Browse repository at this point
Copy the full SHA 27ead4dView commit details -
First examples of the New And Complete ability specs. Now with update…
…d abilities to meet specs.
Configuration menu - View commit details
-
Copy full SHA for e1b56f1 - Browse repository at this point
Copy the full SHA e1b56f1View commit details
Commits on May 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 6b4664e - Browse repository at this point
Copy the full SHA 6b4664eView commit details
Commits on May 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bfaeb99 - Browse repository at this point
Copy the full SHA bfaeb99View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6da595 - Browse repository at this point
Copy the full SHA f6da595View commit details -
Configuration menu - View commit details
-
Copy full SHA for b172a3f - Browse repository at this point
Copy the full SHA b172a3fView commit details
Commits on May 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ec3c037 - Browse repository at this point
Copy the full SHA ec3c037View commit details -
Configuration menu - View commit details
-
Copy full SHA for f84460e - Browse repository at this point
Copy the full SHA f84460eView commit details -
Write tests for desired behaviour of student ability whether or not t…
…o be able to create a new team -PM rspec green
Configuration menu - View commit details
-
Copy full SHA for dad17d8 - Browse repository at this point
Copy the full SHA dad17d8View commit details -
Write tests for desired behaviour of whether a supervisor can or cann…
…ot read a user's email address when it's marked as hidden -PM rspec green
Configuration menu - View commit details
-
Copy full SHA for ff1e8ba - Browse repository at this point
Copy the full SHA ff1e8baView commit details -
Restore old code for can read_email and can users_info. Add tests for…
… desired behaviour - Added new specs to described the intended behaviour whether a supervisor should or should not read hidden email addresses. - PM rspec green
Configuration menu - View commit details
-
Copy full SHA for 975877f - Browse repository at this point
Copy the full SHA 975877fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e5db7d - Browse repository at this point
Copy the full SHA 1e5db7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cabcae9 - Browse repository at this point
Copy the full SHA cabcae9View commit details
Commits on May 21, 2018
-
FIX issue 1003; couldn't solve the abilities and pass the specs witho…
…ut solving the issue :-) - Unchanged: a student cannot create a second team in one season, and can create a team in next season - Fixed: a student in a team in current season doesn't get the '+ new team' button - Fixed: a student in a team in current season has no access to the new team form - Driving by: use the new rails 5 redirect-er to redirect back to the referer or fall back to root. (So that the forbidden access message appears on the page where the user tried something forbidden.) - Update projects_spec for new redirect - Update teams_controller_spec that failed because a student can't create a second team in the same season
1Configuration menu - View commit details
-
Copy full SHA for 6e7d601 - Browse repository at this point
Copy the full SHA 6e7d601View commit details -
Remove one level of nesting in the ability specs, removed the repitio…
…n of testing role abilities.
Configuration menu - View commit details
-
Copy full SHA for 9a0f39b - Browse repository at this point
Copy the full SHA 9a0f39bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e765a2b - Browse repository at this point
Copy the full SHA e765a2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d685da - Browse repository at this point
Copy the full SHA 9d685daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 419bdf7 - Browse repository at this point
Copy the full SHA 419bdf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb126b9 - Browse repository at this point
Copy the full SHA cb126b9View commit details