Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Rearrange, not change the abilities in Ability #997

Merged
merged 20 commits into from
May 23, 2018
Merged

Rearrange, not change the abilities in Ability #997

merged 20 commits into from
May 23, 2018

Commits on May 15, 2018

  1. WIP Rearrange, not change the abilities in Ability, cf recommended be…

    …st practices
    
    This is the work doc.
    Reset to here before continuing
    emcoding committed May 15, 2018
    Configuration menu
    Copy the full SHA
    d00277c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27ead4d View commit details
    Browse the repository at this point in the history
  3. First examples of the New And Complete ability specs. Now with update…

    …d abilities to meet specs.
    emcoding committed May 15, 2018
    Configuration menu
    Copy the full SHA
    e1b56f1 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2018

  1. Halfway

    emcoding committed May 16, 2018
    Configuration menu
    Copy the full SHA
    6b4664e View commit details
    Browse the repository at this point in the history

Commits on May 17, 2018

  1. Configuration menu
    Copy the full SHA
    bfaeb99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6da595 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b172a3f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2018

  1. Finetuning

    - remove redundant conditional
    emcoding committed May 18, 2018
    Configuration menu
    Copy the full SHA
    ec3c037 View commit details
    Browse the repository at this point in the history
  2. Finetuning

    - remove redundant things
    emcoding committed May 18, 2018
    Configuration menu
    Copy the full SHA
    f84460e View commit details
    Browse the repository at this point in the history
  3. Write tests for desired behaviour of student ability whether or not t…

    …o be able to create a new team
    
    -PM rspec green
    emcoding committed May 18, 2018
    Configuration menu
    Copy the full SHA
    dad17d8 View commit details
    Browse the repository at this point in the history
  4. Write tests for desired behaviour of whether a supervisor can or cann…

    …ot read a user's email address when it's marked as hidden
    
    -PM rspec green
    emcoding committed May 18, 2018
    Configuration menu
    Copy the full SHA
    ff1e8ba View commit details
    Browse the repository at this point in the history
  5. Restore old code for can read_email and can users_info. Add tests for…

    … desired behaviour
    
    - Added new specs to described the intended behaviour whether a supervisor should or should not read hidden email addresses.
    
    - PM rspec green
    emcoding committed May 18, 2018
    Configuration menu
    Copy the full SHA
    975877f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1e5db7d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cabcae9 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2018

  1. FIX issue 1003; couldn't solve the abilities and pass the specs witho…

    …ut solving the issue :-)
    
    - Unchanged: a student cannot create a second team in one season, and can create a team in next season
    - Fixed: a student in a team in current season doesn't get the '+ new team' button
    - Fixed: a student in a team in current season has no access to the new team form
    - Driving by: use the new rails 5 redirect-er to redirect back to the referer or fall back to root. (So that the forbidden access message appears on the page where the user tried something forbidden.)
    - Update projects_spec for new redirect
    - Update teams_controller_spec that failed because a student can't create a second team in the same season
    emcoding committed May 21, 2018
    1 Configuration menu
    Copy the full SHA
    6e7d601 View commit details
    Browse the repository at this point in the history
  2. Remove one level of nesting in the ability specs, removed the repitio…

    …n of testing role abilities.
    emcoding committed May 21, 2018
    Configuration menu
    Copy the full SHA
    9a0f39b View commit details
    Browse the repository at this point in the history
  3. 👮

    emcoding committed May 21, 2018
    Configuration menu
    Copy the full SHA
    e765a2b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9d685da View commit details
    Browse the repository at this point in the history
  5. Declutter

    emcoding committed May 21, 2018
    Configuration menu
    Copy the full SHA
    419bdf7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cb126b9 View commit details
    Browse the repository at this point in the history