Blog category updates #435
Conversation
There was a problem hiding this comment.
Apologies it took me so long to review this again. The sidebar changes look great so I'd keep those, but remove the “comma hack”. I've made more detailed comments in the code itself. I'm also going to leave a separate comment regarding what I originally meant with “the categories can't be seen on the blog index” with screenshots so that it's clearer. Thank you so much for all your work so far!
| @@ -36,7 +36,22 @@ <h3 class="l-sidebar__heading">Latest posts</h3> | |||
| <li><a href="{{ post.url }}">{{ post.title }}</a></li> | |||
| {% endfor %} | |||
| </ul> | |||
| <p>See all posts in the <a href="/blog/archive/">archive</a> or <a href="/blog/categoryview">browse by category</a>!</p> | |||
| <p>See all posts in the <a href="/blog/archive/">archive</a> <!-- or <a href="/blog/categoryview">browse by category</a>!--></p> | |||
There was a problem hiding this comment.
This looks great! Thanks 👍
| @@ -99,3 +99,7 @@ | |||
| width: 200px | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think this comma thing is a little too much of a hack, so I would remove it 😅 and just hope we can figure out how to fix it in the future. I also don't think we have the use case very often where a blog post will belong to more than two categories. I really appreciate the effort, Chris!
|
I've made some screenshots (see below) of what I meant originally when I said that you couldn't see the categories on the blog index. Basically, when you go on view from the blog index view from the single blog post |
|
Hej @iamchrissmith, would you be able to and have time to pick up this PR again? There's a few changes I requested which I can help with, and I'd love to see this merged soon! |
|
@alicetragedy I have been meaning to get back to this, but have been diverted by holidays and a new job. I have travel and a move over the next month or so. I would still be happy to get back to this, but it might be a couple of months. Sorry for the delay! |
|
no worries, @iamchrissmith! Totally understandable. I'll put this on the back burner for now and ping you about it again in a few weeks. |
|
Of course, please cherry pick away, don't let me become a blocker :-) |
|
@iamchrissmith sorry for following up so late :) Is this something you'd be able to and be interested in improving? I'm not sure what your time commitment looks like over the next weeks and if you are able to look into this :) |
@alicetragedy I took a look at those other two issues and found a fix for both.
For the first, I assumed you meant someplace in the sidebar, so I moved the category listings there. They still link to the categoryview anchor tags, but will allow users to quickly navigate to posts just in a category.
For the comma issue... yeah I agree that is a weird one. I'm not sure where that space is coming from. After investigating, it looks like it is actually helping us for the 'and' one, so I didn't want to nuke it (even if I could). I ended up adding a css hack (
margin-left:-2px) for the comma which seems to have corrected the issue at least visually.Hope these are helpful!
Chris