Skip to content

v4: Hand-off GVL during dbuse #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

v4: Hand-off GVL during dbuse #597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions ext/tiny_tds/client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,9 +923,19 @@ static VALUE rb_tinytds_identity_sql(VALUE self)
return rb_str_new2(cwrap->identity_insert_sql);
}

// connect function, with some additions to enable handing off the GVL
struct dbuse_args {
DBPROCESS * dbproc;
const char * name;
};

static void *dbuse_without_gvl(void *ptr)
{
struct dbuse_args *args = (struct dbuse_args *)ptr;
dbuse(args->dbproc, args->name);
return NULL;
}

// TinyTds::Client (protected)

static VALUE rb_tinytds_connect(VALUE self)
{
Expand Down Expand Up @@ -1023,7 +1033,20 @@ static VALUE rb_tinytds_connect(VALUE self)
cwrap->userdata->closed = 0;

if (!NIL_P(database) && (azure != Qtrue)) {
dbuse(cwrap->client, StringValueCStr(database));
struct dbuse_args use_args;
use_args.dbproc = cwrap->client;
use_args.name = StringValueCStr(database);

// in case of any errors, the tinytds_err_handler will be called
// so we do not have to check the return code here
nogvl_setup(cwrap->client);
rb_thread_call_without_gvl(
dbuse_without_gvl,
&use_args,
NULL,
NULL
);
nogvl_cleanup(cwrap->client);
}

cwrap->encoding = rb_enc_find(StringValueCStr(charset));
Expand Down
Loading