Skip to content

Commit

Permalink
Remove approval block to run tests, lint, and annotations
Browse files Browse the repository at this point in the history
These steps are designed so any code executed from the workspace happens
inside an unprivileged docker container.

We would get faster feedback on PRs if these run instantly.
  • Loading branch information
zzak committed Dec 2, 2024
1 parent 13b395c commit 1d56bf7
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions pipelines/buildkite-config/initial.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,6 @@
# This config is intended for running the rails/buildkite-config CI.

steps:
- block: "Review Build Script"
branches: "!main"
prompt: |
Our CI scripts run outside the docker containers, which are a necessary security layer.
Approving a build here is equivalent to copy & pasting it into a production ssh window.
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
- @matthewd
- group:
label: ":pipeline: buildkite-config meta-ci"
key: "meta"
Expand Down

0 comments on commit 1d56bf7

Please sign in to comment.