make worker thread pools private

rails · Feb 16, 2025 · 0b5e0e7 · 0b5e0e7
1 parent 2a25d7f
commit 0b5e0e7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/solid_queue/worker.rb b/lib/solid_queue/worker.rb
@@ -8,8 +8,6 @@ class Worker < Processes::Poller
     before_shutdown :run_stop_hooks
     after_shutdown :run_exit_hooks
 
-    attr_accessor :pool
-
     attr_reader :worker_id, :queues
 
     def initialize(**options)
@@ -29,6 +27,8 @@ def metadata
     end
 
     private
+      attr_reader :pool
+
       def poll
         claim_executions.then do |executions|
           executions.each do |execution|

diff --git a/test/unit/worker_test.rb b/test/unit/worker_test.rb
@@ -156,7 +156,7 @@ class WorkerTest < ActiveSupport::TestCase
     @worker.start
     wait_for_registered_processes(1, timeout: 1.second)
 
-    assert_not @worker.pool.shutdown?
+    assert_not @worker.instance_variable_get(:@pool).shutdown?
 
     process = SolidQueue::Process.first
     assert_equal "Worker", process.kind
@@ -165,8 +165,8 @@ class WorkerTest < ActiveSupport::TestCase
 
     # And now just wait until the worker tries to heartbeat and realises
     # it needs to stop
-    wait_while_with_timeout(2) { !@worker.pool.shutdown? }
-    assert @worker.pool.shutdown?
+    wait_while_with_timeout(2) { !@worker.instance_variable_get(:@pool).shutdown? }
+    assert @worker.instance_variable_get(:@pool).shutdown?
   ensure
     SolidQueue.process_heartbeat_interval = old_heartbeat_interval
   end