Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwindcss debug environment variable #504

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

r-sierra
Copy link
Contributor

Hi, this PR adds an environment variable to generate non-minified assets as discussed in #400

Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for drafting this! I'd like to simplify the environment variable check, and I'm not sure what to do if both the rake task argument is passed and the environment variable is set.

@r-sierra r-sierra requested a review from flavorjones February 24, 2025 14:20
@r-sierra
Copy link
Contributor Author

Hi @flavorjones, thanks for taking the time to review this changes. This is ready for another review.

@flavorjones
Copy link
Member

I rebased and made a small change from unless ENV[].nil? to if ENV.key?(). This looks great! Will merge when it goes green.

Thank you!

@flavorjones flavorjones merged commit 5ecd3a0 into rails:main Feb 25, 2025
17 checks passed
flavorjones added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants