Skip to content

fix(mcp): enforce exact submit_work_proof format enum #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keilogic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mcp): enforce exact submit_work_proof format enum #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/mcp_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,14 @@ def optional_clean_str_arg(field: str) -> str | None:
return clean or None

def output_format_arg() -> str:
value = args.get("format", "text")
if value is None:
if "format" not in args:
return "text"
value = args["format"]
if not isinstance(value, str):
raise ValueError("format must be a string")
normalized = value.strip().lower()
if normalized not in {"text", "json"}:
if value not in {"text", "json"}:
raise ValueError("format must be text or json")
return normalized
return value

def optional_repo_selector_arg() -> str | None:
repo = optional_clean_str_arg("repo")
Expand Down
3 changes: 3 additions & 0 deletions tests/test_api_mcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1810,10 +1810,13 @@ def test_mcp_submit_work_proof_scopes_issue_number_by_repo(sqlite_url: str) -> N
({"bounty_id": 1, "issue_number": 1}, 25),
({"format": "xml"}, 26),
({"format": 1}, 27),
({"format": None}, 28),
({"repo": "ramimbo/mergework"}, 29),
({"bounty_id": 1, "repo": "ramimbo/mergework"}, 30),
({"issue_number": 1, "repo": 1}, 31),
({"issue_number": 1, "repo": "a" * 201}, 32),
({"format": "JSON"}, 33),
({"format": " json "}, 34),
],
)
def test_mcp_submit_work_proof_rejects_invalid_bounty_selectors(
Expand Down
Loading