Upstream Mike PR #329 review

[github-actions]

Automated-Upstream-Mike-Sync: true
Upstream-Risk: high

Promising workflow-restructure hardening, but it depends on an undecided high-risk architecture involving schemas, authorization, storage, and governance.

Mike PR Open-Legal-Products#329

• Outcome: needs-decision
• Capability: workflow-restructure-hardening
• Series: workflow-restructure-309
• Dependencies: Mike PR feat(workflows): restructure workflows and quick actions Open-Legal-Products/mike#309, Mike PR feat(word-addin): align chat UI with web app Open-Legal-Products/mike#299
• Prerequisites: Approve or reject the feat(workflows): restructure workflows and quick actions Open-Legal-Products/mike#309 editable workflow-catalog model, Schema, migration, authorization, storage, and tenant-boundary review, Approve workflow provenance, defaults, add-on catalog, and quick-action policy, ROSS-native backend, frontend, and optional Word add-in test harness
• Reason: The crash, atomicity, error-state, and catalog-efficiency fixes are useful, but they harden feat(workflows): restructure workflows and quick actions Open-Legal-Products/mike#309’s unimplemented schema and catalog architecture and include protected migration, authorization, provenance, and CI changes.

Architecture brief

If Open-Legal-Products#309 is approved, implement its hardening at ROSS’s existing buildWorkflowStore, workflow routes, generated governed catalogs, and workflow UI seams while preserving Ontario provenance controls. Treat Word add-in behavior separately because current ROSS has no corresponding add-in seam.

Implementation plan

• Decide the feat(workflows): restructure workflows and quick actions Open-Legal-Products/mike#309 product model and whether PR feat(word-addin): align chat UI with web app Open-Legal-Products/mike#299’s Word add-in is in scope.
• Threat-model ownership checks, catalog synchronization, asset replication, and tenant isolation.
• Design migrations and rollback against current ROSS schema and RLS expectations.
• Map failure containment into buildWorkflowStore and route error handling without weakening validation.
• Add focused fault-injection, atomic replication, catalog idempotency, provenance, ownership, and UI error-state tests.
• Implement bounded ROSS-native slices only after architecture and governance approval.

Required human action

This is a draft state-only architecture record. Review the brief and implementation plan before any code is attempted.