Upstream Mike PR #291 review - #129
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated-Upstream-Mike-Sync: true
Upstream-Risk: high
Promising coverage-ratchet capability, but ROSS lacks the required frontend test harness and one upstream seam. Adding the harness would change dependencies and lockfiles, requiring an explicit decision.
Mike PR open-legal-products#291
ROSS-native contract tests for frontend API wrappers and model helpers, backed by a measured no-regression coverage ratchetfrontend-lib-coverageArchitecture brief
Add an isolated frontend unit-test layer around current ROSS library contracts, using mocked transport boundaries and coverage limited to stable library seams. Establish ratchet floors only from reproducible ROSS measurements, not upstream values.
Implementation plan
Required human action
This is a draft state-only architecture record. Review the brief and implementation plan before any code is attempted.