Fixes issues 2301 and 2383 AttributeError: module 'requests.cookies' has no attribute 'update' #2388
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMkl
changed the title
JanMkl
force-pushed
the
fix-issue-2301
branch
2 times, most recently
from
7b79946 to
1387b91
Compare
|
@ValueRaider can you check this? |
|
Not important |
ValueRaider
requested changes
Mar 26, 2025
- In utils.py line 165 if the session is None then _requests is mistakenly passed to as session to data.py which causes attribute error: module 'requests.cookies' has no attribute 'update' - The above condition happens only when searching tickers with ISIN numbers - Added tests with ISIN numbers - Added tickerBase to raise an ValueError if an empty tickername is passed or isin search results in to empty ticker. This is to have consistent behaviour with utils.get_all_by_isin() - Corrected ruff check failures - Rebasing to latest upstream/dev - Updated the value error to contain the ISIN number that wasn't found
|
conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires that PR #2382 is first merged otherwise new tests introduced for ISIN will fail to same error as #2343 and #2363