-
Notifications
You must be signed in to change notification settings - Fork 261
Make the projects workflow page reference the backingNamespace field #2075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make the projects workflow page reference the backingNamespace field #2075
Conversation
LucasSaintarbor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonCrowther Thanks for the PR! Requesting some changes, if they look okay, please apply them to the other versions. Thanks!
docs/how-to-guides/new-user-guides/manage-clusters/projects-and-namespaces.md
Outdated
Show resolved
Hide resolved
LucasSaintarbor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonCrowther Sorry one last nit that I missed. Thanks!
| ``` | ||
|
|
||
| to list projectroletemplatebindings in the project's namespace: | ||
| to list projectroletemplatebindings in the project's backing namespace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| to list projectroletemplatebindings in the project's backing namespace: | |
| To list projectroletemplatebindings in the project's backing namespace: |
| ``` | ||
|
|
||
| to list projectroletemplatebindings in the project's namespace: | ||
| to list projectroletemplatebindings in the project's backing namespace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| to list projectroletemplatebindings in the project's backing namespace: | |
| To list projectroletemplatebindings in the project's backing namespace: |
| ``` | ||
|
|
||
| to list projectroletemplatebindings in the project's namespace: | ||
| to list projectroletemplatebindings in the project's backing namespace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| to list projectroletemplatebindings in the project's backing namespace: | |
| To list projectroletemplatebindings in the project's backing namespace: |
| ``` | ||
|
|
||
| to list projectroletemplatebindings in the project's namespace: | ||
| to list projectroletemplatebindings in the project's backing namespace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| to list projectroletemplatebindings in the project's backing namespace: | |
| To list projectroletemplatebindings in the project's backing namespace: |
| ``` | ||
|
|
||
| to list projectroletemplatebindings in the project's namespace: | ||
| to list projectroletemplatebindings in the project's backing namespace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| to list projectroletemplatebindings in the project's backing namespace: | |
| To list projectroletemplatebindings in the project's backing namespace: |
| ``` | ||
|
|
||
| to list projectroletemplatebindings in the project's namespace: | ||
| to list projectroletemplatebindings in the project's backing namespace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| to list projectroletemplatebindings in the project's backing namespace: | |
| To list projectroletemplatebindings in the project's backing namespace: |
Fixes #2066
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Projects used to create backing namespaces that had the same name as the project ID. That has been changed to use a new field in the project CR itself called
backingNamespace. The docs had not been updated to reference this new field and were therefore incorrect in how to create project members.Comments
I also added a link to the workflow page from the preexisting projects doc so that way people can find it more easily.
There are also a couple of points that are written as "mandatory" when they aren't, so I corrected that as well.