Convert string None
to Python None
#218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #208, it appears that the conversion of the string "None" to the python None object wasn't implemented in the
parse_combine_counts_args
function unlike the parse_combine_counts_fw_args
function. This results in the error shown in #208. Therefore, it seems that thephase_snps
step is not treated as optional whenfixed_width = False
.Closes #208
Testing Results
When
It successfully passed check without failing.
@mmyers1 @balabanmetin Please let me know if you want me to run additional tests.