-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Update windows wmi to persistence mixin #20706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
h00die
wants to merge
7
commits into
rapid7:master
Choose a base branch
from
h00die:windows_wmi_persistence
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,386
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoles
reviewed
Nov 19, 2025
modules/exploits/windows/persistence/wmi/wmi_event_subscription_waitfor.rb
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for the kind words and updating the module. |
Contributor
Author
|
Ready for review! |
Contributor
|
@h00die i guess you are splitting the modules so they can be targetted better by the persistence suggester correct? |
Contributor
Author
|
Yup, that and there's a lot of different functionality that I felt got lost by having so many targets/methods, and options changing based on the target/method. Just made sense to me to KISS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the windows wmi persistence to the new mixin. The original persistence worked in several different and very cool ways, and I felt it would be best to split them out instead of complicating the datastore based on which technique was chosen. Part of #20374
@NickTyrer not sure if you are still around, but I love this module, its stealthy, the module was well written and easy to follow. Props from future!
As noted in the files:
wmic will be removed Windows 11, version 25H2 or Windows 11, version 24H2 in favor of powershell
source https://support.microsoft.com/en-us/topic/windows-management-instrumentation-command-line-wmic-removal-from-windows-e9e83c7f-4992-477f-ba1d-96f694b8665d
To Do:
Finish testing each module (only event_log is done)
Write docs
Make cleanup work (currently failing)
Verification
msfconsoleuse exploit/windows/persistence/wmi/<select a module>set SESSION <id>exploit