Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default build arg generation to rapids-rattler-channel-string #156

Open
gforsyth opened this issue Feb 28, 2025 · 0 comments · May be fixed by rapidsai/gha-tools#151
Open

Add default build arg generation to rapids-rattler-channel-string #156

gforsyth opened this issue Feb 28, 2025 · 0 comments · May be fixed by rapidsai/gha-tools#151
Assignees

Comments

@gforsyth
Copy link

gforsyth commented Feb 28, 2025

rapidsai/cudf#18054 (comment)

We always pass (at least):

--experimental \
--no-build-id \

to all rattler-build commands. We can handle the arg generation in gha-tools and centralize any changes to those args we need to make.

--channel-priority disabled is another one we use everywhere, although that we will want to relax individually, so I'm inclined to keep it separate

Changed my mind, i think we should also include --channel-priority in the centralized args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant