-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port all conda recipes to rattler-build
#18054
Conversation
rattler-build
62b6a58
to
69f7b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments attached. Please also see my review on UCXX and apply any relevant requests from that PR to this one, too.
Computers are the absolute worst. Despite
|
Ok, wrapping in quotation marks works. It's very strange that this happens in only some repos, but I'll add "wrap these in strings all the time" to the rattler playbook |
88d20a4
to
1c05304
Compare
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only a few leftover comments. However, I think we should merge this soon and work out the remaining items in a follow-up PR wherever we can. Getting this in will help us see any problems, and it'll help with reducing merge conflicts with other work that is going on.
3c6573e
to
ac2429e
Compare
/ok to test |
bec4719
to
e27c1f3
Compare
Is there a minimal "expected" behavior here that we could capture and write up in a rattler issue? |
I think it might be: Given that shells have horrendously inconsistent behavior around types, make everything a string unless someone explicitly calls |
That seems sensible. Want to write that up as a rattler-build issue? |
will do |
rattler-build issue for context types: prefix-dev/rattler-build#1451 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks Gil! I have some open requests, but nothing worth blocking on so I'm approving now so that you can move ahead. Three requests beyond what I put in-line:
- Can you go through and resolve all the open discussion threads on this PR? There are a lot, and I want to make sure that we don't miss anything.
- For any changes that we've decided to punt on for this PR but that we do want to make, could we start documenting them somewhere? I'm fine if we just use something like a google doc (issues feel like extra overhead for how tiny many of the requests are) but it would be good to not lose track of things.
- In future PRs, could you please avoid force-pushing? We try to avoid those because they decouple the discussion history from the source since the commits vanish.
@vyasr thanks for the review -- I'm tracking all of the remaining open requests here: rapidsai/build-planning#47 (comment) in re: force-pushing, it was a necessary evil because of some unverified commits from one of the lab machines that was continuously blocking CI from running, but I'll avoid it in the future. |
/merge |
Description
Port all condabuild recipes over to use
rattler-build
instead.Contributes to rapidsai/build-planning#47
rattler
, this changes all the licenses in thepyproject.toml
files to the SPDX-compliantApache-2.0
instead ofApache 2.0
Checklist